-
Notifications
You must be signed in to change notification settings - Fork 1
feat(iapp)!: support bulk processing #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PierreJeanjacquot
merged 13 commits into
main
from
feature/iapp-support-bulk-processing
Nov 10, 2025
Merged
feat(iapp)!: support bulk processing #82
PierreJeanjacquot
merged 13 commits into
main
from
feature/iapp-support-bulk-processing
Nov 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change 'total-processed' to 'total-count' in bulk result - Change 'dataset-results' to 'results' in bulk result - Remove status field from bulk result object - Update tests to match new structure
- Change output file extension from .txt to .json for better semantic accuracy - Rename 'dataset' field to 'protected-data' in bulk processing results - Improve error messages with 'Cause:' prefix and use 'protected-data' terminology - Update all tests to match new structure and file extensions
- App always create result files - upon success `result.json` contains `"success": true` (rather than `"status": 200`) - upon failure `result.json` contains `"success": false` and the error message in `"error"` (rather than `"status": 4xx | 5xx`)
d23d97f to
c2ce92d
Compare
PierreJeanjacquot
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for bulk processing
App output
result.jsonchangesTests:
BREAKING CHANGE: result file renamed to
result.json; single protectedData result file now contains{"success": <boolean>, "protectedData"?: <address>, "error"?: <string> }; upon error, the iapp will now exit 0 and output"success": falseand"error": <string>rather than falling the task.